matriv commented on a change in pull request #17341:
URL: https://github.com/apache/flink/pull/17341#discussion_r717378373
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CoalesceFunctionITCase.java
##########
@@ -40,23 +41,28 @@
.onFieldsWithData(null, null, 1)
.andDataTypes(BIGINT().nullable(), INT().nullable(),
INT().notNull())
.testResult(
- coalesce($("f0"), $("f1")),
- "COALESCE(f0, f1)",
- null,
- BIGINT().nullable())
- .testResult(
- coalesce($("f0"), $("f2")),
- "COALESCE(f0, f2)",
- 1L,
- BIGINT().notNull())
- .testResult(
- coalesce($("f1"), $("f2")), "COALESCE(f1,
f2)", 1, INT().notNull())
- .testResult(
- coalesce($("f0"), 1),
- "COALESCE(f0, 1)",
- 1L,
- // In this case, the return type is not null
because we have a
- // constant in the function invocation
- BIGINT().notNull()));
+ of(
Review comment:
Sure, I'd prefer though the name `resultSpec()` since `resultItem` is
another more lower level pojo within the class and can cause confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
