Airblader commented on a change in pull request #17384:
URL: https://github.com/apache/flink/pull/17384#discussion_r719328578
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java
##########
@@ -75,7 +75,7 @@ public StreamExecSink(
String description) {
super(
tableSinkSpec,
-
tableSinkSpec.getTableSink().getChangelogMode(inputChangelogMode),
+ inputChangelogMode,
Review comment:
I don't follow; it still does, this is now done in
`CommonExecSink#applyKeyBy` which calls
`tableSink.getChangelogMode(inputChangelogMode)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
