twalthr commented on a change in pull request #17384:
URL: https://github.com/apache/flink/pull/17384#discussion_r719477270
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java
##########
@@ -109,12 +110,12 @@ public DynamicTableSinkSpec getTableSinkSpec() {
@SuppressWarnings("unchecked")
protected Transformation<Object> createSinkTransformation(
- StreamExecutionEnvironment env,
- TableConfig tableConfig,
+ PlannerBase planner,
Transformation<RowData> inputTransform,
int rowtimeFieldIndex,
boolean upsertMaterialize) {
- final DynamicTableSink tableSink = tableSinkSpec.getTableSink();
+ final DynamicTableSink tableSink = tableSinkSpec.getTableSink(planner);
+ final ChangelogMode inputChangelogMode =
tableSink.getChangelogMode(changelogMode);
Review comment:
sorry, but I still fine this confusing. Shouldn't this variable be
called `changelogMode` and the member `inputChangelogMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
