AHeise commented on a change in pull request #17106:
URL: https://github.com/apache/flink/pull/17106#discussion_r719478106
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousProcessingTimeTrigger.java
##########
@@ -74,6 +74,11 @@ public TriggerResult onEventTime(long time, W window,
TriggerContext ctx) throws
@Override
public TriggerResult onProcessingTime(long time, W window, TriggerContext
ctx)
throws Exception {
+
+ if (time == window.maxTimestamp()) {
Review comment:
Is this guaranteed to work? I haven't found any indication that there is
always a call `onProcessingTime(window.maxTimestamp(), window, ctx)`?
Maybe it would work consistently with `long nextFireTimestamp =
Math.min(start + interval, window.maxTimestamp());`. Then state, timer state,
and this method are actually in sync and we wouldn't need this special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
