AHeise commented on a change in pull request #17106:
URL: https://github.com/apache/flink/pull/17106#discussion_r723015486
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousProcessingTimeTrigger.java
##########
@@ -74,6 +74,11 @@ public TriggerResult onEventTime(long time, W window,
TriggerContext ctx) throws
@Override
public TriggerResult onProcessingTime(long time, W window, TriggerContext
ctx)
throws Exception {
+
+ if (time == window.maxTimestamp()) {
Review comment:
Yes, I'd go with all the places + EventTimeTrigger if it suffers from
the same limitation. I'd divide the changes in ProcessingTimeTrigger and
EventTimeTrigger into 2 commits though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
