twalthr commented on a change in pull request #17369:
URL: https://github.com/apache/flink/pull/17369#discussion_r719504153
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/IntervalJoinJsonPlanTest.java
##########
@@ -82,18 +82,19 @@ public void testProcessingTimeInnerJoinWithOnClause() {
@Test
public void testRowTimeInnerJoinWithOnClause() {
- String sinkTableDdl =
- "CREATE TABLE MySink (\n"
- + " a int,\n"
- + " b varchar\n"
- + ") with (\n"
- + " 'connector' = 'values',\n"
- + " 'table-sink-class' = 'DEFAULT')";
- tEnv.executeSql(sinkTableDdl);
util.verifyJsonPlan(
"INSERT INTO MySink "
+ "SELECT t1.a, t2.b FROM A t1 JOIN B t2 ON\n"
+ " t1.a = t2.a AND\n"
+ " t1.rowtime BETWEEN t2.rowtime - INTERVAL '10'
SECOND AND t2.rowtime + INTERVAL '1' HOUR");
}
+
+ @Test
+ public void testRowTimeEquiJoin() {
Review comment:
We can drop this test. A regular plan test via xml should be sufficient
compared to a full JSON plan. If not already present, you can add this to the
test that verifies `IntervalJoinTest.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
