tillrohrmann commented on a change in pull request #17398:
URL: https://github.com/apache/flink/pull/17398#discussion_r721224859
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionConnectionHandlingTest.java
##########
@@ -131,7 +130,8 @@ private void runTestWithZooKeeperConnectionProblem(
Problem problem)
throws Exception {
CuratorFramework client =
- ZooKeeperUtils.startCuratorFramework(configuration,
NoOpFatalErrorHandler.INSTANCE);
+ ZooKeeperUtils.startCuratorFramework(
+ configuration,
fatalErrorHandlerResource.getFatalErrorHandler());
Review comment:
Good point, I think I should go over all the
`startCuratorFramework(Configuration, FatalErrorHandler)` call sites and check
that we don't only use a `NoOpFatalErrorHandler` if we expect an exception to
be thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
