Aitozi commented on a change in pull request #17398:
URL: https://github.com/apache/flink/pull/17398#discussion_r722003005
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionConnectionHandlingTest.java
##########
@@ -131,7 +130,8 @@ private void runTestWithZooKeeperConnectionProblem(
Problem problem)
throws Exception {
CuratorFramework client =
- ZooKeeperUtils.startCuratorFramework(configuration,
NoOpFatalErrorHandler.INSTANCE);
+ ZooKeeperUtils.startCuratorFramework(
+ configuration,
fatalErrorHandlerResource.getFatalErrorHandler());
Review comment:
After going over all the call sites from
`startCuratorFramework(Configuration, FatalErrorHandler)`. I think only the
place which use client to create `LeaderRetrieval/LeaderElectionService` should
replace using `NoOpFatalErrorHandler` with the explicit
`fatalErrorHandlerResource`
```
ZooKeeperLeaderRetrievalTest
ZooKeeperLeaderRetrievalConnectionHandlingTest
ZooKeeperLeaderElectionTest
ZooKeeperLeaderElectionConnectionHandlingTest
ZooKeeperHaServicesTest
ZooKeeperDefaultDispatcherRunnerTest
LeaderElectionTest
```
WDYT @tillrohrmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
