fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727143646
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -80,14 +80,15 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
helper.validate();
validateConfigOptions(config);
JdbcConnectorOptions jdbcOptions = getJdbcOptions(config);
- TableSchema physicalSchema =
-
TableSchemaUtils.getPhysicalSchema(context.getCatalogTable().getSchema());
return new JdbcDynamicTableSink(
jdbcOptions,
getJdbcExecutionOptions(config),
- getJdbcDmlOptions(jdbcOptions, physicalSchema),
- physicalSchema);
+ getJdbcDmlOptions(
+ jdbcOptions,
+ context.getCatalogTable().getUnresolvedSchema(),
Review comment:
Similar problem to the comment before I did not find a good way to
represent the column type information and the primary key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
