fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727156469
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcDataTypeTest.java
##########
@@ -101,50 +101,46 @@
createTestItem("postgresql", "ARRAY<INTEGER>"),
// Unsupported types throws errors.
- createTestItem(
- "derby", "BINARY", "The Derby dialect doesn't support
type: BINARY(1)."),
createTestItem(
"derby",
- "VARBINARY(10)",
- "The Derby dialect doesn't support type:
VARBINARY(10)."),
+ "BINARY",
+ "Unsupported conversion from data type 'BINARY(1)'
(conversion class: [B) to type information. Only data types that originated
from type information fully support a reverse conversion."),
Review comment:
Unfortunately, I am not really sure what the correct behavior here is.
The problem is that this complete test never used the new JDBC connector and
always tested with the old one which is now removed. It appears that with the
new connector the exception signatures have changed.
Are you proposing to drop the test class completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
