JingGe commented on a change in pull request #17501:
URL: https://github.com/apache/flink/pull/17501#discussion_r732878761
##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -26,7 +26,7 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-formats</artifactId>
<version>1.15-SNAPSHOT</version>
- <relativePath>..</relativePath>
+ <relativePath>../pom.xml</relativePath>
Review comment:
There are plenty logics implemented in the StreamFormatAdapter, as I
mentioned in the "open questions" section, why should I do my own
implementation again from BulkFormat instead of reusing them? The design idea
is to let BulkStream handle batch and let StreamFormat/FileRecordFormat handle
streaming, afaik. Your question is leading actually to a fundamental question:
why do we need StreamFormat/FileRecordFormat if we can implement everything
from the BulkFormat which supports both batch and streaming, quoted from your
word, I didn't see any reference about this conclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
