JingGe commented on a change in pull request #17501:
URL: https://github.com/apache/flink/pull/17501#discussion_r733820258
##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -26,7 +26,7 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-formats</artifactId>
<version>1.15-SNAPSHOT</version>
- <relativePath>..</relativePath>
+ <relativePath>../pom.xml</relativePath>
Review comment:
The batch and stream we are talking here refer to reading data not the
execution. I think it is an interesting discussion whether BulkFormat alone is
a good fit to run streaming execution with batch read, the latency could be an
issue.
For the `RecordFormat`, it is considered from the architecture perspective,
because the `FileRecordFormat` and `StreamFormat` are very similar. And
currently, more features have been built for StreamFormat than
FileRecordFormat, Compression is only used as (wrong) example which is not used
for parquet, there could be more others. We should keep an eye on DRY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
