slinkydeveloper commented on pull request #17522: URL: https://github.com/apache/flink/pull/17522#issuecomment-948625872
> If this is the case we can also move most of the code out of flink-table-common and only keep the CastExecutor and the interface of CastExecutorProvider there. Yep, as you see this PR adds in table common only `CastExecutor`, `CastRule` and `CastRulePredicate`. Perhaps we can just keep `CastExecutor` in common, but I prefer to keep all three of them as I think they logically belong together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
