[
https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433774#comment-17433774
]
Piotr Nowojski edited comment on FLINK-24384 at 10/25/21, 2:00 PM:
-------------------------------------------------------------------
Ohh, thanks for the explanation [~Feifan Wang]. Now I understand the issue.
Sorry for the misunderstandment from my side.
Yes, I agree. The *numberOfCompletedCheckpoints* metric should be increased
whenever we are bumping the tolerable checkpoint counter number. I think we
should unify this, and actually track that metric inside
{{CheckpointFailureManager}}? That would avoid similar problems in the future.
Is this only a feature request from your side [~Feifan Wang], or would you like
to work on this?
was (Author: pnowojski):
Ohh, thanks for the explanation [~Feifan Wang]. Now I understand the issue.
Sorry for the misunderstandment from my side.
Yes, I agree. The *numberOfCompletedCheckpoints* metric should be increased
whenever we are bumping the tolerable checkpoint counter number.
I think we should unify this, and actually track that metric inside
{{CheckpointFailureManager}}? That would avoid similar problems in the future.
Is this only a feature request from your side [~Feifan Wang], or would you like
to work on this?
> Count checkpoints failed in trigger phase into numberOfFailedCheckpoints
> ------------------------------------------------------------------------
>
> Key: FLINK-24384
> URL: https://issues.apache.org/jira/browse/FLINK-24384
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing, Runtime / Metrics
> Affects Versions: 1.14.1
> Reporter: Feifan Wang
> Priority: Major
>
> h1. *Problem*
> In current implementation, checkpoints failed in trigger phase do not count
> into metric 'numberOfFailedCheckpoints'. Such that users can not aware
> checkpoint stoped by this metric.
> As lang as users can use rules like _*'numberOfCompletedCheckpoints' not
> increase in some minutes past*_ (maybe checkpoint interval + timeout) for
> alerting, but I think it is ambages and can not alert timely.
>
> h1. *Proposal*
> As the title, count checkpoints failed in trigger phase into
> 'numberOfFailedCheckpoints'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
