akalash commented on a change in pull request #17473:
URL: https://github.com/apache/flink/pull/17473#discussion_r735646141
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloater.java
##########
@@ -94,10 +97,10 @@ public void recalculateBufferSize(long currentThroughput) {
return;
}
- lastBufferSize = newSize;
for (IndexedInputGate inputGate : inputGates) {
inputGate.announceBufferSize(newSize);
}
+ lastBufferSize = newSize;
Review comment:
The main idea of this change is to avoid updating the local value if the
announcement fails. Right now, after one fix it doesn't make sense because if
the announcement fails we restart the task but anyway this order when we
announce and only then update the local value looks correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
