twalthr commented on a change in pull request #17344:
URL: https://github.com/apache/flink/pull/17344#discussion_r740052182
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsAggregatePushDown.java
##########
@@ -124,8 +124,6 @@
*
* <p>Regardless if this interface is implemented or not, a final aggregation
is always applied in a
* subsequent operation after the source.
- *
- * <p>Note: currently, the {@link SupportsAggregatePushDown} is not supported
by planner.
Review comment:
@iyupeng are we sure that the JavaDocs don't need more updates for this
PR?
For example, is this description still correct?
```
* <p>Note: The local aggregate push down strategy is all or nothing, it can
only be pushed down if
* all aggregate functions are supported.
```
Also maybe we should mention the config option that was added in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
