zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741699912



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
                     miniClusterConfiguration.getRpcServiceSharing() == 
RpcServiceSharing.SHARED;
 
             try {
+                final PluginManager pluginManager =
+                        
PluginUtils.createPluginManagerFromRootFolder(configuration);
+                FileSystem.initialize(configuration, pluginManager);

Review comment:
       I don't think so because all tests using the `MiniClusters` implicitly 
go through the `LocalEnvironment.`
   
   While it is true that users cannot set credentials via the configuration 
passed to the environment, they could call `FileSystem#initialize()` themselves.
   Yes, it is surprising and not ergonomic and all that.
   
   Alternatively we would need a way to reset the `FileSystem` (i.e., call 
initialize again with no configuration) after each test.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to