dawidwys commented on a change in pull request #17645:
URL: https://github.com/apache/flink/pull/17645#discussion_r743646338
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java
##########
@@ -296,6 +298,9 @@ private void runWithChecks(RunnableWithException r) throws
Exception {
r.run();
} catch (Exception e) {
fail(e);
+ if (!findThrowable(e, IOException.class).isPresent()) {
Review comment:
Was it your intention to ignore exceptions with `IOException` at any
position in the stack? Shouldn't we ignore only top level `IOException`.
BTW, I find the logic a bit confusing. What is so different between
`IOException`s and all the other? Shouldn't we treat them the same? Could you
elaborate on cases when we don't want to ignore the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
