ysymi commented on a change in pull request #17698:
URL: https://github.com/apache/flink/pull/17698#discussion_r744387331
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html
##########
@@ -29,14 +29,16 @@
<thead>
<tr>
<th>Log Name</th>
- <th>Size (KB)</th>
+ <th [nzSortFn]="sortLastModifiedTimeFn">Last Modified Time</th>
+ <th [nzSortFn]="sortSizeFn">Size (KB)</th>
</tr>
</thead>
<tbody>
- <tr *ngFor="let log of listOfLog">
+ <tr *ngFor="let log of table.data">
Review comment:
Thanks for review code firstly.
I think table.data's type here is `TaskManagerLogItemInterface[]` and
table.data's type in `job-manager-log-list.component.html` is
`JobManagerLogItemInterface[]`.
I read the doc of
[NG_ZORRO#table](https://ng.ant.design/components/table/en#components-table-demo-basic)
, and it's said that table.data's value is set by nz-table's property
`[nzData]`, so I passed `listOfLog` to `nzData` which is defined in related .ts
file .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
