NicoK commented on a change in pull request #42:
URL: https://github.com/apache/flink-training/pull/42#discussion_r745353261
##########
File path: common/build.gradle
##########
@@ -14,11 +14,11 @@ dependencies {
// Compile-time dependencies that should NOT be part of the
// shadow jar and are provided in the lib folder of Flink
// --------------------------------------------------------------
- shadow
"org.apache.flink:flink-runtime_${scalaBinaryVersion}:${flinkVersion}"
+ shadow "org.apache.flink:flink-runtime:${flinkVersion}"
Review comment:
nit: actually, this dependency can also be removed since it is a
transitive dependency from the ones defined in the main `build.gradle` file at
the root project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
