pnowojski commented on a change in pull request #17229:
URL: https://github.com/apache/flink/pull/17229#discussion_r746633905
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -387,6 +390,13 @@ protected StreamTask(
this.stateBackend = createStateBackend();
this.checkpointStorage = createCheckpointStorage(stateBackend);
+ this.changelogWriterAvailabilityProvider =
+ environment.getTaskStateManager().getStateChangelogStorage()
== null
+ ? () -> AvailabilityProvider.AVAILABLE // todo:
benchmark
+ : environment
+ .getTaskStateManager()
+ .getStateChangelogStorage()
+ .getAvailabilityProvider();
Review comment:
Good point. I don't know how to properly solve it.
+0 for the current proposal, maybe we can revisit it in the future if
someone comes up with a better alternative? In the future we could also rename
it to `getTaskStateManager().getAvailabilityProvider()`, and how it's
implemented underneath would be an implementation detail from the
`StreamTask`'s perspective. But for now a more descriptive
`getTaskStateManager().getStateChangelogStorage().getAvailabilityProvider()`
maybe is a good enough solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
