pnowojski commented on a change in pull request #17229:
URL: https://github.com/apache/flink/pull/17229#discussion_r750162802
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -303,6 +304,8 @@
@GuardedBy("shouldInterruptOnCancelLock")
private boolean shouldInterruptOnCancel = true;
+ private final AvailabilityProvider changelogWriterAvailabilityProvider;
Review comment:
Which version/parameters did you mean when reporting networkThroughput?
I presume `1000,1ms`? If so, I think those results are fine. Those results are
well within the noise of those benchmarks. I think except of
`WindowBenchmarks.globalWindow`, all of the other results are within the
min/max of last 10 runs.
Nevertheless we should check the long term trends after merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
