weibozhao commented on a change in pull request #24:
URL: https://github.com/apache/flink-ml/pull/24#discussion_r747286229
##########
File path:
flink-ml-lib/src/main/java/org/apache/flink/ml/params/knn/KnnClassifierParams.java
##########
@@ -0,0 +1,4 @@
+package org.apache.flink.ml.params.knn;
+
+/** knn train parameters. */
+public interface KnnClassifierParams<T> extends KnnTrainParams<T>,
KnnPredictParams<T> {}
Review comment:
1. XXXX Params is the params of algorithm, not infra
2. predict is the action of model.
3. Estimator is the api algo user can see. train is the inner process in the
Estimator.
4. Classifier is one kind of estimator, Regressor and Cluster also can be an
estimator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
