weibozhao commented on a change in pull request #24:
URL: https://github.com/apache/flink-ml/pull/24#discussion_r747332694
##########
File path:
flink-ml-lib/src/main/java/org/apache/flink/ml/params/knn/KnnClassifierParams.java
##########
@@ -0,0 +1,4 @@
+package org.apache.flink.ml.params.knn;
+
+/** knn train parameters. */
+public interface KnnClassifierParams<T> extends KnnTrainParams<T>,
KnnPredictParams<T> {}
Review comment:
1. predict is a inner concept, not a api (like transform)
2. I think: estimator is the abstract classes of classifier, regressor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
