xuyangzhong commented on a change in pull request #17771:
URL: https://github.com/apache/flink/pull/17771#discussion_r748951364
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -193,7 +193,6 @@ private static void testError(
} catch (AssertionError e) {
throw e;
} catch (Throwable t) {
- assertTrue(t instanceof ValidationException);
Review comment:
Because a TableException may also be thrown here when we check the
invalid implicit type conversion between numeric and (var)char. I think
writing another catch like `catch (TableException e ) ... ` is unnecessary and
I can reuse 　the code here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
