slinkydeveloper commented on a change in pull request #17768:
URL: https://github.com/apache/flink/pull/17768#discussion_r749305236



##########
File path: 
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDecodingFormat.java
##########
@@ -43,7 +44,8 @@
 import java.util.stream.Stream;
 
 /** {@link DecodingFormat} for Canal using JSON encoding. */
-public class CanalJsonDecodingFormat implements 
DecodingFormat<DeserializationSchema<RowData>> {
+public class CanalJsonDecodingFormat

Review comment:
       You mean only for this specific format? I think it's safe for all our 
formats to be projected, in particular for json.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to