slinkydeveloper commented on a change in pull request #17768:
URL: https://github.com/apache/flink/pull/17768#discussion_r749347486



##########
File path: 
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java
##########
@@ -176,23 +179,47 @@ public ScanRuntimeProvider 
getScanRuntimeProvider(ScanContext scanContext) {
                     && filters.size() > 0) {
                 ((BulkDecodingFormat<RowData>) 
bulkReaderFormat).applyFilters(filters);
             }
-            BulkFormat<RowData, FileSourceSplit> bulkFormat =
+
+            BulkFormat<RowData, FileSourceSplit> format =

Review comment:
       Creating a method for that is not trivial because of the different 
return type of the `DecodingFormat`, I've refactored with `if/else`, I hope it 
helps




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to