tsreaper commented on pull request #17794: URL: https://github.com/apache/flink/pull/17794#issuecomment-969648661
> I'm not sure if the sink is the only location that breaks with rowtime being NULL. I'm wondering whether we should allow this at all. It could cause a couple of issues in downstream operators. Maybe it is better to make the column `NOT NULL` during the schema resolution? I've searched the usage and see a few more methods directly calling `getMillisecond` without checking for nulls. I think we should unify the behavior for records with rowtime being null (for example we just discard the records) instead of throwing exceptions because this is not friendly for streaming job users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
