yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r749921048
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/datastream/EndOfStreamWindows.java ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.common.datastream; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.windowing.assigners.WindowAssigner; +import org.apache.flink.streaming.api.windowing.triggers.EventTimeTrigger; +import org.apache.flink.streaming.api.windowing.triggers.Trigger; +import org.apache.flink.streaming.api.windowing.windows.TimeWindow; + +import java.util.Collection; +import java.util.Collections; + +/** + * A {@link WindowAssigner} that windows elements into windows based on the timestamp of the + * elements. Windows cannot overlap. + * + * <p>For example, in order to window into windows of 1 minute: + * + * <pre>{@code + * DataStream<Tuple2<String, Integer>> in = ...; + * KeyedStream<Tuple2<String, Integer>, String> keyed = in.keyBy(...); + * WindowedStream<Tuple2<String, Integer>, String, TimeWindow> windowed = + * keyed.window(TumblingEventTimeWindows.of(Time.minutes(1))); + * }</pre> + */ +@PublicEvolving +public class EndOfStreamWindows extends WindowAssigner<Object, TimeWindow> { + + private static final EndOfStreamWindows INSTANCE = new EndOfStreamWindows(); + + private EndOfStreamWindows() {} + + public static EndOfStreamWindows get() { + return INSTANCE; + } + + @Override + public Collection<TimeWindow> assignWindows( + Object element, long timestamp, WindowAssignerContext context) { + return Collections.singletonList(new TimeWindow(Long.MIN_VALUE, Long.MAX_VALUE)); Review comment: I just confirmed with Lin Dong as this is his code. He agrees that we can create a global static variable here and reuse it every time we call `assignWindows()`. He will make this change in next version of his code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
