yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r749958347
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesParams.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.classification.naivebayes; + +import org.apache.flink.ml.param.DoubleParam; +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.ParamValidators; +import org.apache.flink.ml.param.shared.colname.HasFeatureCols; +import org.apache.flink.ml.param.shared.colname.HasLabelCol; +import org.apache.flink.ml.param.shared.colname.HasPredictionCol; + +/** + * Parameters of naive bayes training process. + */ +public interface NaiveBayesParams<T> extends Review comment: OK. I'll add this param to NaiveBayes. One consideration is that while spark supports setting the type of a whole Naive Bayes model, Alink allows finer granularity to define the model type for each feature column. I agree that we just need to define the type of a whole model in the foreseeable future, but if users need to define type for each column they will need to create multiple NaiveBayesModel and use some bagging algorithm to unify them into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
