[GitHub] [flink] beyond1920 commented on a change in pull request #17637: [FLINK-24708][planner] Fix wrong results of the IN operator

Tue, 16 Nov 2021 01:51:29 -0800 


beyond1920 commented on a change in pull request #17637:
URL: https://github.com/apache/flink/pull/17637#discussion_r750090428



##########
File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/ConvertToNotInOrInRule.scala
##########
@@ -184,6 +188,54 @@ class ConvertToNotInOrInRule
       case _ => rexNodes.size >= THRESHOLD
     }
   }
+

Review comment:
       Could we use the following method to fix?
   
![image](https://user-images.githubusercontent.com/1525333/141961739-0592f735-f466-42f3-a571-a0de2b0c56df.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to