[ 
https://issues.apache.org/jira/browse/FLINK-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444896#comment-17444896
 ] 

Kurt Young commented on FLINK-24924:
------------------------------------

I would second [~TsReaper] 's concern and i remember we have faced such dilemma 
before. Imagine an online job has been ran for couple of weeks and suddenly 
failed by some unexpected dirty data. What choices do users have to quickly 
resume the job? 

> TO_TIMESTAMP and TO_DATE should fail
> ------------------------------------
>
>                 Key: FLINK-24924
>                 URL: https://issues.apache.org/jira/browse/FLINK-24924
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Francesco Guardiani
>            Priority: Major
>
> In a similar fashion to what described 
> https://issues.apache.org/jira/browse/FLINK-24385, TO_TIMESTAMP and TO_DATE 
> should fail instead of returning {{null}}.
> In particular for these two functions, a failure in parsing could lead to 
> very unexpected behavior, for example it could lead to records with null 
> rowtime.
> We should change these functions to fail by default when parsing generates an 
> error. We can let users handle errors by letting them use TRY_CAST for the 
> same functionality:
> {code:sql}
> -- This fails when input is invalid
> TO_TIMESTAMP(input)
> -- Behaves the same as above
> CAST(input AS TIMESTAMP)
> -- This returns null when input is invalid
> TRY_CAST(input AS TIMESTAMP)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to