Aitozi commented on a change in pull request #17685:
URL: https://github.com/apache/flink/pull/17685#discussion_r750886768
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java
##########
@@ -64,10 +63,15 @@ public KubernetesJobManagerParameters(
.getOptional(KubernetesConfigOptions.JOB_MANAGER_LABELS)
.orElse(Collections.emptyMap()));
labels.putAll(getCommonLabels());
Review comment:
@wangyang0918 Yes, But I think the selector do not always rely on the
common labels. So I do not remove this line.
So that we do not have to care about the details of selector and common
labels (although the selector contains the common labels, now), We just have to
make them up to build the jobManager and taskManager labels. It's my
consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
