Airblader commented on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-972766538
OK, I hopefully have resolved the issues with Maven now, let's see what the CI says. Essentially when run in Maven, the dependencies come in as JARs (d'oh). But previously, I had the import option to exclude JARs enabled. Disabling that option in turn blew up memory usage and the whole thing OOM'ed. I now added an import option to exclude shaded stuff, and that seems to work fine even with default memory settings. Also, the current execution time for the tests is more on the order of a few seconds, not three minutes, so :tada: to that. The PR now also contains two commits which resolve some of the violations that seemed trivial to resolve. There's plenty of non-trivial ones, and once (and if) we have this merged I'd like to go through more of them to either resolve them or create dedicated issues for some of the more tricky ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
