pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754005566
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -123,12 +123,12 @@ public long getCount() {
}
private static final String PREFIX = "changelogStorage";
Review comment:
Bumping `ChangelogStorage` from the previous comment?
(This one I'm not sure what's or what should be our convention)
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java
##########
@@ -92,6 +103,16 @@ public void upload(Collection<UploadTask> tasks) throws
IOException {
}
}
+ private LocalResult uploadWithMetrics(Path path, Collection<UploadTask>
tasks)
+ throws IOException {
+ metrics.getUploadsCounter().inc();
+ long start = clock.relativeTimeNanos();
+ LocalResult result = upload(path, tasks);
+ metrics.getUploadLatencies().update(clock.relativeTimeNanos() - start);
Review comment:
Would it be better to have millis or nanos precision here?
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State
Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup>
{
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new
ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new
ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX +
".uploadRequests";
Review comment:
`totalNumberOfUploadRequests`? `totalNumberOfUploads`?
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State
Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup>
{
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new
ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new
ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX +
".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX +
".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX +
".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX +
".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX +
".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_QUEUE_SIZE = PREFIX +
".queueSize";
Review comment:
`currentUploadQueueSize`? `pendingUploads`? `numberOfPendingUploads`?
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State
Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup>
{
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new
ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new
ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX +
".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX +
".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX +
".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX +
".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX +
".logsPerUpload";
Review comment:
It's hard for me to deduce the meaning of this metric from this name?
Can you either propose something more descriptive or explain for me what is the
meaning of this metric?
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State
Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup>
{
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new
ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new
ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX +
".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX +
".uploadFailures";
Review comment:
`numberOfUploadFailures`?
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -123,12 +123,12 @@ public long getCount() {
}
private static final String PREFIX = "changelogStorage";
- public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX +
".upload-requests";
- public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX +
".upload-failures";
- public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX +
".upload-sizes";
- public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX +
".upload-latencies";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX +
".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX +
".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX +
".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX +
".uploadLatencies";
Review comment:
`uploadLatencies` -> `uploadLatenciesNanos` or `uploadLatenciesMs`
(depending on another comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
