pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754397298
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java
##########
@@ -92,6 +103,16 @@ public void upload(Collection<UploadTask> tasks) throws
IOException {
}
}
+ private LocalResult uploadWithMetrics(Path path, Collection<UploadTask>
tasks)
+ throws IOException {
+ metrics.getUploadsCounter().inc();
+ long start = clock.relativeTimeNanos();
+ LocalResult result = upload(path, tasks);
+ metrics.getUploadLatencies().update(clock.relativeTimeNanos() - start);
Review comment:
I was asking about how to present this value to the users (webUI/metric
reporters/logs/...) (so, `b)`). Indeed maybe nanos is a bit better here, "just
in case we need this extra precision in the future".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
