rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754477778
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -134,6 +138,6 @@ public long getCount() {
PREFIX + ".uploadLatenciesNanos";
public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
PREFIX + ".attemptsPerUpload";
- public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX +
".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_UPLOAD_BATCH_SIZES = PREFIX +
".uploadBatchSizes";
Review comment:
The word "request" is already used in sense "request to DFS"
(`numberOfUploadRequests` as discussed above).
But maybe we should have
- `numberOfUploadRequests` -> `numberOfUploads`
- `uploadBatchSizes` -> `incomingRequestsPerUpload` or
`incomingRequestsPerBatch`
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
