wuchong commented on pull request #17754: URL: https://github.com/apache/flink/pull/17754#issuecomment-976346619
Thanks @gaurav726 for the great work. The implementation looks good to me. However, I have some concerns about the option key. From my point of view, this issue wants to disable caching missing key (same problem with FLINK-21415). Therefore, this option key would be better to belong to `lookup.cache.xx`. How about naming it `lookup.cache.caching-missing-key=true` which looks more intuitive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
