Aitozi commented on a change in pull request #41:
URL: https://github.com/apache/flink-benchmarks/pull/41#discussion_r754968540
##########
File path:
src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java
##########
@@ -52,10 +56,21 @@
final ThreadLocalRandom random = ThreadLocalRandom.current();
@Param({"HEAP", "ROCKSDB"})
- protected StateBackendBenchmarkUtils.StateBackendType backendType;
+ private StateBackendBenchmarkUtils.StateBackendType backendType;
+
+ @Param({"/tmp"})
Review comment:
It's indeed have different behavior, because it's depends on the
`java.io.tmpdir` property.
The `@param` do not accept `null`, so I use `not_set` as default value .
```
# Warmup: 10 iterations, 1 s each
# Measurement: 10 iterations, 1 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Throughput, ops/time
# Benchmark: org.apache.flink.state.benchmark.ValueStateBenchmark.valueAdd
# Parameters: (backendType = HEAP, stateDataDirPath = not_set)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
