dmvk commented on a change in pull request #17693:
URL: https://github.com/apache/flink/pull/17693#discussion_r755360040



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
##########
@@ -1479,6 +1485,72 @@ public void testLateRegisteredPartitionsWillBeReleased() 
{
         assertThat(shuffleMaster.getExternallyReleasedPartitions(), 
hasSize(1));
     }
 
+    @Test
+    public void testCheckpointCleanerIsClosedAfterCheckpointServices() throws 
Exception {
+        final JobGraph jobGraph = singleJobVertexJobGraph(1);
+        enableCheckpointing(jobGraph);
+        final CountDownLatch checkpointServicesShutdownBlocked = new 
CountDownLatch(1);
+        final CountDownLatch cleanerClosed = new CountDownLatch(1);

Review comment:
       I'm aware of that class, but I'm probably missing some intuition behind 
it. Why is better than using java primitive that does the same thing?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to