fapaul commented on a change in pull request #17870:
URL: https://github.com/apache/flink/pull/17870#discussion_r756154531
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertSink.java
##########
@@ -43,19 +45,19 @@
private final DataType physicalDataType;
private final int[] keyProjection;
private final SinkBufferFlushMode bufferFlushMode;
- private final Function<RowData, RowData> valueCopyFunction;
+ @Nullable private final TypeSerializer<RowData> typeSerializer;
ReducingUpsertSink(
Sink<RowData, ?, WriterState, ?> wrappedSink,
DataType physicalDataType,
int[] keyProjection,
SinkBufferFlushMode bufferFlushMode,
- Function<RowData, RowData> valueCopyFunction) {
Review comment:
I think making the function serializable did not really work because of
the object reuse that the sink is using ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
