fapaul commented on a change in pull request #17870:
URL: https://github.com/apache/flink/pull/17870#discussion_r756637602



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSink.java
##########
@@ -228,10 +227,8 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context 
context) {
                                         flushMode,
                                         objectReuse
                                                 ? createRowDataTypeSerializer(
-                                                                context,
-                                                                
dataStream.getExecutionConfig())
-                                                        ::copy
-                                                : Function.identity());

Review comment:
       None of those functions is serializable therefore we cannot pass them 
directly to the sink.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to