JingGe edited a comment on pull request #17888:
URL: https://github.com/apache/flink/pull/17888#issuecomment-979792504


   > Can you give a bit more context on how the current change fixes the 
problem? It would be also great to write a paragraph in the commit message 
about how the commit fixes the behavior to make it easier to understand the 
change.
   > 
   > I also saw that the `HBaseConnectorITCase` in the `hbase1` module uses the 
exact same code we should probably also apply the fixes to this file.
   
   Thanks for reviewing, I am not really sure what kinds of information did you 
require. All changes have been described exactly both in the PR change log and 
in the commit, and the code change is quite simple and explained itself. If 
you'd like to know the background context, FLINK-24077 would be the feasible 
source of the truth for it. For `hbase1`, that is the weird part, because we 
have only been seeing issues for `hbase2`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to