JingGe commented on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-979802188
> > Thanks for reviewing, I am not really sure what kinds of information did you require. All changes have been described exactly both in the PR change log and in the commit, and the code change is quite simple and explained itself. If you'd like to know the background context, [FLINK-24077](https://issues.apache.org/jira/browse/FLINK-24077) would be the feasible source of the truth for it. For `hbase1`, that is the weird part, because we have only been seeing issues for `hbase2`. > > I am missing the point of why the made changes fix the problem. AFAICT they are only additional checks but do not change the test behavior. I see, first of all, as described in the PR title and the previous conversation, the issues happened sporadically, there is no way to reproduce it locally, this PR is trying to fix it. Second, IMHO, any modification does change the test behavior, not to mention adding tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
