nicoweidner commented on a change in pull request #17893:
URL: https://github.com/apache/flink/pull/17893#discussion_r757476431
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
##########
@@ -446,7 +447,7 @@ public void setTolerableCheckpointFailureNumber(int
tolerableCheckpointFailureNu
* @param cleanupMode Externalized checkpoint cleanup behaviour.
*/
@PublicEvolving
- public void enableExternalizedCheckpoints(ExternalizedCheckpointCleanup
cleanupMode) {
+ public void setExternalizedCheckpointCleanup(ExternalizedCheckpointCleanup
cleanupMode) {
Review comment:
Woops. Thanks, that's something I am obviously not yet sensitive to. I
will keep the old one and let it call a new method.
On the note of `@Public` and `@PublicEvolving`: CheckpointConfig has
`@Public`, but some of its methods have `@PublicEvolving`. How does that make
sense? On behalf of the former, I would expect that all methods of the class
must have stable interfaces.
This might be related to there not being a clear opinion on whether these
annotations are "inherited" by the methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
