nicoweidner commented on a change in pull request #17893:
URL: https://github.com/apache/flink/pull/17893#discussion_r758393156
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java
##########
@@ -88,16 +88,18 @@
+ "we do not tolerance any checkpoint
failure.");
public static final
ConfigOption<CheckpointConfig.ExternalizedCheckpointCleanup>
- EXTERNALIZED_CHECKPOINT =
+ EXTERNALIZED_CHECKPOINT_CLEANUP =
ConfigOptions.key("execution.checkpointing.externalized-checkpoint-retention")
.enumType(CheckpointConfig.ExternalizedCheckpointCleanup.class)
- .noDefaultValue()
+ .defaultValue(
+
CheckpointConfig.ExternalizedCheckpointCleanup
+ .NO_EXTERNALIZED_CHECKPOINTS)
.withDescription(
Description.builder()
.text(
"Externalized checkpoints
write their meta data out to persistent storage and are not "
+ "automatically
cleaned up when the owning job fails or is suspended (terminating with job "
- + "status %s or
%s. In this case, you have to manually clean up the checkpoint state, both the "
+ + "status %s or
%s). In this case, you have to manually clean up the checkpoint state, both the
"
Review comment:
I left this description as it does not really describe the options, but
rather the consequences for the users (you have to clean up leftover
checkpoints yourself). Do you think it's too much overlap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
