slinkydeveloper opened a new pull request #17931:
URL: https://github.com/apache/flink/pull/17931
## What is the purpose of the change
This PR refactors `PlannerExpressionParser` to be loaded through the
`Factory` SPI infrastructure. It also renames `PlannerExpressionParser` to
`ExpressionParser`, as the original name is misleading (is it a parser or a
planner?!) and it's implicit the fact that the implementation is planner
provided, given it lives in the `org.apache.flink.table.delegation` package.
## Brief change log
* Renamed `PlannerExpressionParser` to `ExpressionParser`
* Added a new `ExpressionParserFactory` to load the `ExpressionParser` and
added the `DefaultExpressionParserFactory`
* Removed `org.apache.flink.table.expressions.ExpressionParser` as it
doesn't provide any particular value
* Removed `WindowCreationValidationTest` which haven't much sense now.
Previously, they were testing the reflection failure with the nice exception,
but now we use the `FactoryUtil` methods which are already well tested
Note that the git changelog confuses the `PlannerExpressionParser` renaming
with the removal of `org.apache.flink.table.expressions.ExpressionParser`.
## Verifying this change
This change is a trivial rework / code cleanup already covered by existing
tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
