godfreyhe commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r758001359
##########
File path:
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/ProjectWindowTableFunctionTransposeRuleTest.xml
##########
@@ -16,7 +16,43 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
<Root>
- <TestCase name="testNoColumnToPrune">
+ <TestCase name="testNoColumnToPrune[isStreamingMode=false]">
Review comment:
just add tests for project-transpose in WindowTableFunctionTest which is
enough I think. We need e2e plan test for this case instead of function test
for ProjectWindowTableFunctionTransposeRule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]