shenzhu commented on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-982309892
Hey @Airblader , I got some architecture tests failing for this PR, the failing messages are as follows ``` java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'Return and argument types of methods annotated with @PublicEvolving must be annotated with @Public(Evolving).' was violated (3 times): org.apache.flink.table.catalog.Catalog.renameFunction(org.apache.flink.table.catalog.ObjectPath, java.lang.String, boolean): Argument leaf type org.apache.flink.table.catalog.ObjectPath does not satisfy: reside outside of package 'org.apache.flink..' or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated org.apache.flink.table.catalog.Catalog.renameFunction(org.apache.flink.table.catalog.ObjectPath, java.lang.String, boolean): Exception leaf type org.apache.flink.table.catalog.exceptions.FunctionAlreadyExistException does not satisfy: reside outside of package 'org.apache.flink..' or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated org.apache.flink.table.catalog.Catalog.renameFunction(org.apache.flink.table.catalog.ObjectPath, java.lang.String, boolean): Exception leaf type org.apache.flink.table.catalog.exceptions.FunctionNotExistException does not satisfy: reside outside of package 'org.apache.flink..' or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated ``` Later I [added `@PublicEvolving` annotation](https://github.com/apache/flink/pull/17788/commits/c693223bdadb16abe3c2f9b1fe53891bf1a69460) and that fixed these tests, however, I thought `ObjectPath`, `FunctionAlreadyExists` and `FunctionNotExists` are not intended for public use(not sure I'm correct here). Based on the [README](https://github.com/apache/flink/commit/b6af27e1229c8922ca9ea6e1f71dd5adeef2b7c7#diff-b723668ed95dd063b89b7edc675b3d514b1fe0107f97eda9b2cd635108d0461fR20), should I create a JIRA issue for this? Thanks for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
