twalthr commented on a change in pull request #17941:
URL: https://github.com/apache/flink/pull/17941#discussion_r759115303
##########
File path: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh
##########
@@ -37,20 +37,10 @@ function setup_elasticsearch {
local elasticsearchDir=$TEST_DATA_DIR/elasticsearch
mkdir -p $elasticsearchDir
echo "Downloading Elasticsearch from $downloadUrl ..."
- for i in {1..10};
- do
- wget "$downloadUrl" -O $TEST_DATA_DIR/elasticsearch.tar.gz
- if [ $? -eq 0 ]; then
- echo "Download successful."
- echo "Extracting..."
- tar xzf $TEST_DATA_DIR/elasticsearch.tar.gz -C $elasticsearchDir
--strip-components=1
- if [ $? -eq 0 ]; then
- break
- fi
- fi
- echo "Attempt $i failed."
- sleep 5
- done
+ retry_times_with_exponential_backoff 10 wget "$downloadUrl" -O
$TEST_DATA_DIR/elasticsearch.tar.gz
+ echo "Download successful."
+ echo "Extracting..."
+ tar xzf $TEST_DATA_DIR/elasticsearch.tar.gz -C $elasticsearchDir
--strip-components=1
Review comment:
we could offer an optional hash argument, if the hash is not correct we
do the the retry logic as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
